Adding comments to YAML files for documentation#91
Closed
draychev wants to merge 1 commit intoAzure:mainfrom
Closed
Adding comments to YAML files for documentation#91draychev wants to merge 1 commit intoAzure:mainfrom
draychev wants to merge 1 commit intoAzure:mainfrom
Conversation
nshankar13
reviewed
Apr 21, 2021
| # The job in this YAML file tries to add 'openservicemesh.io/ignore' label to 'kube-system', 'azure-arc', and 'arc-osm-system' namespaces. | ||
| # The job is executed in helm pre-install phase of OSM release lifecycle. | ||
| # | ||
| # The job in this file adds 'openservicemesh.io/ignore' label to 'kube-system', 'azure-arc', and 'arc-osm-system' namespaces. |
Contributor
There was a problem hiding this comment.
We should also add that the job adds the "admission.policy.azure.com/ignore" label to the arc-osm-system namespace.
SanyaKochhar
approved these changes
Apr 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few comments to YAML files for clarity.